Skip to content

Add ruff.toml, pre-commit#264

Closed
hemildesai wants to merge 2 commits intomainfrom
hemil/pre-commit
Closed

Add ruff.toml, pre-commit#264
hemildesai wants to merge 2 commits intomainfrom
hemil/pre-commit

Conversation

@hemildesai
Copy link
Copy Markdown
Contributor

@hemildesai hemildesai commented Jun 8, 2025

No description provided.

@hemildesai
Add ruff.toml, pre-commit
6ca24dd 
Signed-off-by: Hemil Desai <hemild@nvidia.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 8, 2025
View reviewed changes
nemo_run/cli/api.py
from nemo_run.cli import experiment as experiment_cli
from nemo_run.cli.cli_parser import parse_cli_args, parse_factory
from nemo_run.cli.config import ConfigSerializer
from nemo_run.cli.lazy import LazyEntrypoint

Check notice

Code scanning / CodeQL

Cyclic import Note

Import of module
nemo_run.cli.lazy
Loading
begins an import cycle.

Copilot Autofix

AI 10 months ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

nemo_run/cli/lazy.py

from omegaconf import OmegaConf

from nemo_run.cli.config import ConfigSerializer

Check notice

Code scanning / CodeQL

Cyclic import Note

Import of module
nemo_run.cli.config
Loading
begins an import cycle.

Copilot Autofix

AI 10 months ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

test/cli/test_api.py
from typer.testing import CliRunner

import nemo_run as run
import nemo_run.cli.cli_parser # Import the module to mock its function

Check notice

Code scanning / CodeQL

Unused import Note test

Import of 'nemo_run' is not used.

Copilot Autofix

AI 10 months ago

To fix the issue, the unused import statement import nemo_run.cli.cli_parser on line 31 should be removed. This will eliminate the unnecessary dependency and improve code readability. No additional changes are required, as the removal of this import does not affect the functionality of the code.

Suggested changeset 1
test/cli/test_api.py

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/test/cli/test_api.py b/test/cli/test_api.py
--- a/test/cli/test_api.py
+++ b/test/cli/test_api.py
@@ -30,3 +30,3 @@
 import nemo_run as run
-import nemo_run.cli.cli_parser  # Import the module to mock its function
+
 from nemo_run import cli, config
EOF
@@ -30,3 +30,3 @@
import nemo_run as run
import nemo_run.cli.cli_parser # Import the module to mock its function

from nemo_run import cli, config
Copilot is powered by AI and may make mistakes. Always verify output.
@hemildesai
fix
a0ebeb4 
Signed-off-by: Hemil Desai <hemild@nvidia.com>
@hemildesai hemildesai requested review from chtruong814 and ko3n1g June 9, 2025 05:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 24, 2025

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 24, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 31, 2025

This PR was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ko3n1g ko3n1g Awaiting requested review from ko3n1g

@chtruong814 chtruong814 Awaiting requested review from chtruong814

Assignees

No one assigned

Labels

Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hemildesai